Wenzhe Zhou has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/23066 )
Change subject: IMPALA-14005: Support for quoted reserved words column names
......................................................................
IMPALA-14005: Support for quoted reserved words column names
This change updates the way column names are
projected in the SQL query generated for JDBC
external tables. Instead of relying on optional
mapping or default behavior, all column names are now
explicitly quoted using appropriate quote characters.
Column names are now wrapped with quote characters
based on the JDBC driver being used:
1. Backticks (`) for Hive, Impala and MySQL
2. Double quotes (") for all other databases
This helps in the support for case-sensitive or
reserved column names.
Change-Id: I5da5bc7ea5df8f094b7e2877a0ebf35662f93805
Reviewed-on: http://gerrit.cloudera.org:8080/23066
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Wenzhe Zhou <[email protected]>
---
M fe/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java
M testdata/bin/create-ext-data-source-table.sql
M testdata/bin/load-ext-data-sources.sh
M testdata/bin/setup-mysql-env.sh
M
testdata/workloads/functional-query/queries/QueryTest/hive-jdbc-mysql-tables.test
M
testdata/workloads/functional-query/queries/QueryTest/hive-jdbc-postgres-tables.test
M tests/custom_cluster/test_ext_data_sources.py
7 files changed, 473 insertions(+), 6 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Wenzhe Zhou: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/23066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5da5bc7ea5df8f094b7e2877a0ebf35662f93805
Gerrit-Change-Number: 23066
Gerrit-PatchSet: 9
Gerrit-Owner: Pranav Lodha <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
Gerrit-Reviewer: Pranav Lodha <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
