Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23190
to look at the new patch set (#4).
Change subject: IMPALA-14237: Fix Iceberg partition values encoding
......................................................................
IMPALA-14237: Fix Iceberg partition values encoding
This patch modifies the string overload of
IcebergFunctions::TruncatePartitionTransform to always handle strings
as UTF-8 encoded ones, because the Iceberg spec states that strings are
UTF-8 encoded.
Also, for an Iceberg table UrlEncode is called in non-Hive compatible
way, rather than a standard way, similar to Java's URLEncoder.encode()
(what Iceberg API also uses).
Testing:
* add e2e tests to check partitions with Unicode characters
* add be tests to coding-util-test.cc
Change-Id: Iabb39727f6dd49b76c918bcd6b3ec62532555755
---
M be/src/exec/table-sink-base.cc
M be/src/exprs/iceberg-functions-ir.cc
M be/src/util/coding-util-test.cc
M be/src/util/coding-util.cc
M
testdata/workloads/functional-query/queries/QueryTest/iceberg-partition-transform-insert.test
M testdata/workloads/functional-query/queries/QueryTest/unicode-column-name.test
M tests/query_test/test_insert.py
7 files changed, 108 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/90/23190/4
--
To view, visit http://gerrit.cloudera.org:8080/23190
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iabb39727f6dd49b76c918bcd6b3ec62532555755
Gerrit-Change-Number: 23190
Gerrit-PatchSet: 4
Gerrit-Owner: Daniel Vanko <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
