Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23080 )
Change subject: IMPALA-13947: Test local catalog mode by default ...................................................................... Patch Set 4: Code-Review+2 (4 comments) Sorry to be late here. I think we should merge this to ease other catalog works, e.g. Iceberg REST catalog support. Feel free to carry on my +2. http://gerrit.cloudera.org:8080/#/c/23080/4/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java: http://gerrit.cloudera.org:8080/#/c/23080/4/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@4016 PS4, Line 4016: To be consistent with other tests, can we add "%s" here to use the 'overwrite' variable? I.e. AnalysisError(String.format("load data inpath '%s' %s into table " + "functional_seq.alltypes partition(year=2009, month=3)", "/test-warehouse/alltypes_seq/year=2009/month=5", overwrite), "Unable to LOAD DATA into target table (functional_seq.alltypes) because " + "Impala does not have WRITE access to HDFS location: " + "hdfs://localhost:20500/test-warehouse/alltypes_seq/year=2009/month=3"); http://gerrit.cloudera.org:8080/#/c/23080/2/testdata/workloads/functional-query/queries/QueryTest/kudu-timeouts-impalad.test File testdata/workloads/functional-query/queries/QueryTest/kudu-timeouts-impalad.test: http://gerrit.cloudera.org:8080/#/c/23080/2/testdata/workloads/functional-query/queries/QueryTest/kudu-timeouts-impalad.test@14 PS2, Line 14: Kudu error: cannot complete before timeout > Tracked in IMPALA-7507. Ack. I think this is due to a behavior change that in local-catalog mode, coordinator loads Kudu table schema from Kudu directly (instead of using metadata propagated from catalogd in legacy catalog mode). So we see the timeout error happens earlier now, i.e. in StmtMetadataLoader.loadTables() instead of Frontend.createExecRequest(). Changing the error message makes sense. http://gerrit.cloudera.org:8080/#/c/23080/2/tests/custom_cluster/test_query_live.py File tests/custom_cluster/test_query_live.py: http://gerrit.cloudera.org:8080/#/c/23080/2/tests/custom_cluster/test_query_live.py@178 PS2, Line 178: 'org.apache.impala.catalog' in str(insert_result) : assert 'SystemTable' in str(insert_result) > I split it this way to catch both apache.impala.catalog.local.LocalSystemTa Ack http://gerrit.cloudera.org:8080/#/c/23080/2/tests/custom_cluster/test_services_rpc_errors.py File tests/custom_cluster/test_services_rpc_errors.py: http://gerrit.cloudera.org:8080/#/c/23080/2/tests/custom_cluster/test_services_rpc_errors.py@103 PS2, Line 103: -1 > -1 means at least 1 match expected. Done -- To view, visit http://gerrit.cloudera.org:8080/23080 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie303e294972d12b98f8354bf6bbc6d0cb920060f Gerrit-Change-Number: 23080 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 06 Aug 2025 15:33:38 +0000 Gerrit-HasComments: Yes
