Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22716 )
Change subject: IMPALA-13011: Support authorization for Calcite in Impala ...................................................................... Patch Set 12: (1 comment) Minor nit. I still have to go through this one more time since I didn't review the register logic the first time, but I like this much better! http://gerrit.cloudera.org:8080/#/c/22716/12/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteParsedStatement.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteParsedStatement.java: http://gerrit.cloudera.org:8080/#/c/22716/12/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteParsedStatement.java@104 PS12, Line 104: validator.registerTablePrivReqs(getTablesInQuery(/* loader */ null), catalog); Small nit (if possible)... I think it makes sense to still register the tables in the CalciteAnalysisDriver. If I'm not mistaken, we can register before doing the cloning? If so, then let's move these 2 register statements back into CalciteAnalysisDriver before calling validate. -- To view, visit http://gerrit.cloudera.org:8080/22716 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a7f7e4dc9a86a2da9e387832e552538e34029c1 Gerrit-Change-Number: 22716 Gerrit-PatchSet: 12 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 31 Jul 2025 16:44:22 +0000 Gerrit-HasComments: Yes
