Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22716 )
Change subject: IMPALA-13011: [WIP] Support authorization for Calcite in Impala ...................................................................... Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/22716/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteAnalysisDriver.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteAnalysisDriver.java: http://gerrit.cloudera.org:8080/#/c/22716/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteAnalysisDriver.java@131 PS11, Line 131: CalciteParsedStatement parsedStmtForPrivReqsReg = > > The intention was to make CalciteParsedStatement an immutable object, so Ok, so after further review, heh...this is a problem with the original code (submitted by me), not yours! Sorry! But having said that, I think it still makes sense to do this and now seems like a good time to make the change. Would you be able to do this? Thanks! http://gerrit.cloudera.org:8080/#/c/22716/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteAnalysisDriver.java@143 PS11, Line 143: impalaPrivReqsReg.validate(parsedStmtForPrivReqsReg.getParsedSqlNode()); > > I noticed validate() is also called within the ImpalaPrivReqsReg object. Yes, sounds like we are in agreement here. Let's do this! Thanks! -- To view, visit http://gerrit.cloudera.org:8080/22716 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a7f7e4dc9a86a2da9e387832e552538e34029c1 Gerrit-Change-Number: 22716 Gerrit-PatchSet: 11 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 28 Jul 2025 22:57:31 +0000 Gerrit-HasComments: Yes
