Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22878 )
Change subject: IMPALA-14016: Add multi-catalog support for local catalog mode ...................................................................... Patch Set 4: (3 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22878/4/fe/src/main/java/org/apache/impala/catalog/local/MultiMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/MultiMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/22878/4/fe/src/main/java/org/apache/impala/catalog/local/MultiMetaProvider.java@259 PS4, Line 259: public <R> Collection<R> collectFromAllProviders(java.util.function.Function<MetaProvider, R> function) line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/22878/4/java/iceberg-rest-catalog-test/src/main/java/org/apache/iceberg/rest/IcebergRestCatalogTest.java File java/iceberg-rest-catalog-test/src/main/java/org/apache/iceberg/rest/IcebergRestCatalogTest.java: http://gerrit.cloudera.org:8080/#/c/22878/4/java/iceberg-rest-catalog-test/src/main/java/org/apache/iceberg/rest/IcebergRestCatalogTest.java@46 PS4, Line 46: private static final String DEFAULT_HADOOP_CATALOG_LOCATION = "/test-warehouse/iceberg_test/hadoop_catalog"; line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/22878/4/tests/custom_cluster/test_iceberg_rest_catalog.py File tests/custom_cluster/test_iceberg_rest_catalog.py: http://gerrit.cloudera.org:8080/#/c/22878/4/tests/custom_cluster/test_iceberg_rest_catalog.py@37 PS4, Line 37: y flake8: E501 line too long (99 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/22878 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifbdd0f7085345e7954d9f6f264202699182dd1e1 Gerrit-Change-Number: 22878 Gerrit-PatchSet: 4 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 28 Jul 2025 15:12:56 +0000 Gerrit-HasComments: Yes
