Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23219 )
Change subject: [PROTOTYPE] IMPALA-13437 (part 2): Add cost-based tuple cache placement ...................................................................... Patch Set 1: (3 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23219/1/fe/src/test/java/org/apache/impala/planner/TpcdsTupleCachePlannerTest.java File fe/src/test/java/org/apache/impala/planner/TpcdsTupleCachePlannerTest.java: http://gerrit.cloudera.org:8080/#/c/23219/1/fe/src/test/java/org/apache/impala/planner/TpcdsTupleCachePlannerTest.java@705 PS1, Line 705: runPlannerTestFile("tpcds_tuple_cache/tpcds-q43-verbose", testDb, options, testOptions); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/23219/1/fe/src/test/java/org/apache/impala/planner/TpcdsTupleCachePlannerTest.java@718 PS1, Line 718: runPlannerTestFile("tpcds_tuple_cache/tpcds-ddl-parquet", testDb, options, testOptions); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/23219/1/fe/src/test/java/org/apache/impala/planner/TpcdsTupleCachePlannerTest.java@723 PS1, Line 723: runPlannerTestFile("tpcds_tuple_cache/tpcds-ddl-iceberg", testDb, options, testOptions); line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/23219 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifc6e7b95621a7937d892511dc879bf7c8da07cdc Gerrit-Change-Number: 23219 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Sun, 27 Jul 2025 20:29:50 +0000 Gerrit-HasComments: Yes
