Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23066 )

Change subject: IMPALA-14005: Support for quoted reserved words column names
......................................................................


Patch Set 4:

(3 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/23066/4/tests/custom_cluster/test_ext_data_sources.py
File tests/custom_cluster/test_ext_data_sources.py:

http://gerrit.cloudera.org:8080/#/c/23066/4/tests/custom_cluster/test_ext_data_sources.py@316
PS4, Line 316: #
flake8: E265 block comment should start with '# '


http://gerrit.cloudera.org:8080/#/c/23066/4/tests/custom_cluster/test_ext_data_sources.py@362
PS4, Line 362:
flake8: W293 blank line contains whitespace


http://gerrit.cloudera.org:8080/#/c/23066/4/tests/custom_cluster/test_ext_data_sources.py@362
PS4, Line 362:
line has trailing whitespace



--
To view, visit http://gerrit.cloudera.org:8080/23066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5da5bc7ea5df8f094b7e2877a0ebf35662f93805
Gerrit-Change-Number: 23066
Gerrit-PatchSet: 4
Gerrit-Owner: Pranav Lodha <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
Gerrit-Reviewer: Pranav Lodha <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Comment-Date: Sun, 27 Jul 2025 19:17:33 +0000
Gerrit-HasComments: Yes

Reply via email to