Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/23122 )
Change subject: IMPALA-14094: Calcite planner: Use table and column statistics for optimization ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/23122/3/java/calcite-planner/src/test/java/org/apache/impala/planner/TestCalciteStats.java File java/calcite-planner/src/test/java/org/apache/impala/planner/TestCalciteStats.java: http://gerrit.cloudera.org:8080/#/c/23122/3/java/calcite-planner/src/test/java/org/apache/impala/planner/TestCalciteStats.java@66 PS3, Line 66: import static org.junit.Assert.*; nit: import statement with wildcard is not recommended for Impala (I thought this would have failed checkstyle in the build) http://gerrit.cloudera.org:8080/#/c/23122/3/testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q63.test File testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q63.test: http://gerrit.cloudera.org:8080/#/c/23122/3/testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q63.test@260 PS3, Line 260: cardinality=327.58K We used to also display in parenthesis "(filtered from <cardinality>)" .. is that removed intentionally ? -- To view, visit http://gerrit.cloudera.org:8080/23122 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d5bb50eb562c28e4b7c7a6529d140f98e77295c Gerrit-Change-Number: 23122 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 16 Jul 2025 00:49:44 +0000 Gerrit-HasComments: Yes
