Hello Yida Wu, Mihaly Szjatinya, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23140
to look at the new patch set (#8).
Change subject: IMPALA-14207: Hook log4j to Glog in AdmissionD
......................................................................
IMPALA-14207: Hook log4j to Glog in AdmissionD
log4j logs does not shows up in dedicated AdmissionD service. This is
because GlogAppender.Install is not called anywhere. It is called in
constructor of JniCatalog.java and JniFrontend.java, but AdmissionD does
not utilize either of them.
AdmissionD has call path to JniRequestPoolService.java. This patch adds
isAdmissiond parameter to JniRequestPoolService constructor to call
GlogAppender.Install and hook up log4j to Glog. Only AdmissionD will
initialize JniRequestPoolService with this parameter equals True. Note
that this hook up only happen if fair_scheduler_allocation_path flag is
not empty.
Testing:
Run few tests in TestAdmissionControllerWithACService and confirm log4j
logs appears in admissiond.INFO
Change-Id: Ie28ec017f70c79d6ffdc56daa5aaeb9efcb8bb79
---
M be/src/scheduling/admissiond-env.cc
M be/src/scheduling/request-pool-service.cc
M be/src/scheduling/request-pool-service.h
M fe/src/main/java/org/apache/impala/util/JniRequestPoolService.java
M fe/src/main/java/org/apache/impala/util/RequestPoolService.java
5 files changed, 20 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/23140/8
--
To view, visit http://gerrit.cloudera.org:8080/23140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie28ec017f70c79d6ffdc56daa5aaeb9efcb8bb79
Gerrit-Change-Number: 23140
Gerrit-PatchSet: 8
Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <msz...@pm.me>
Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com>
