Yida Wu has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23094 )

Change subject: IMPALA-12057: Track removed coordinators to reject queued 
queries early
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/23094/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23094/1//COMMIT_MSG@24
PS1, Line 24: Added regression test test_coord_not_registered_in_ac.
> We should probably write a custom cluster test for the same.
Added a regression test test_coord_not_registered_in_ac.


http://gerrit.cloudera.org:8080/#/c/23094/1/be/src/scheduling/cluster-membership-mgr.cc
File be/src/scheduling/cluster-membership-mgr.cc:

http://gerrit.cloudera.org:8080/#/c/23094/1/be/src/scheduling/cluster-membership-mgr.cc@222
PS1, Line 222:     state->all_coordinators.RemoveExecutor(*actual_be);
> Commented code can probably be removed?
Done



--
To view, visit http://gerrit.cloudera.org:8080/23094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e0f270299f8c20975d7895c17f4e2791c3360e0
Gerrit-Change-Number: 23094
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
Gerrit-Comment-Date: Tue, 08 Jul 2025 18:45:15 +0000
Gerrit-HasComments: Yes

Reply via email to