Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/23141 )
Change subject: IMPALA-14018: Adding utility scripts to run Lakekeeper in Impala dev envinroment ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/23141/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23141/1//COMMIT_MSG@18 PS1, Line 18: Usage Could you create a README file with these instructions in testdata/bin/minicluster_lakekeeper? http://gerrit.cloudera.org:8080/#/c/23141/1//COMMIT_MSG@27 PS1, Line 27: TODO Do you plan to resolve it in this patch? On the other hand, it may not be intuitive to make Trino a service within the Lakekeeper "ecosystem" as it can be used separately. http://gerrit.cloudera.org:8080/#/c/23141/1//COMMIT_MSG@39 PS1, Line 39: create table trino_t (i int); Shouldn't it be create table iceberg_lakekeeper.trino_d.trino_t (i int); ? Or a USE statement? It fails for me without it. Similarly for the next line. http://gerrit.cloudera.org:8080/#/c/23141/1/testdata/bin/run-lakekeeper.sh File testdata/bin/run-lakekeeper.sh: http://gerrit.cloudera.org:8080/#/c/23141/1/testdata/bin/run-lakekeeper.sh@27 PS1, Line 27: docker compose Should be docker-compose. http://gerrit.cloudera.org:8080/#/c/23141/1/testdata/bin/stop-lakekeeper.sh File testdata/bin/stop-lakekeeper.sh: http://gerrit.cloudera.org:8080/#/c/23141/1/testdata/bin/stop-lakekeeper.sh@22 PS1, Line 22: docker compose Should be docker-compose. -- To view, visit http://gerrit.cloudera.org:8080/23141 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I610f5859f92b2ff82e310f46356e3f118e986b2c Gerrit-Change-Number: 23141 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 08 Jul 2025 09:42:04 +0000 Gerrit-HasComments: Yes
