Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23142 )
Change subject: WIP: do not review ...................................................................... Patch Set 3: (4 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23142/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdRowCount.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdRowCount.java: http://gerrit.cloudera.org:8080/#/c/23142/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdRowCount.java@129 PS3, Line 129: Double selectivity = condition != null ? estimator.estimateSelectivity(condition) : 1.0; line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/23142/3/java/calcite-planner/src/test/java/org/apache/impala/planner/TestCalciteStats.java File java/calcite-planner/src/test/java/org/apache/impala/planner/TestCalciteStats.java: http://gerrit.cloudera.org:8080/#/c/23142/3/java/calcite-planner/src/test/java/org/apache/impala/planner/TestCalciteStats.java@332 PS3, Line 332: PrunedPartitionHelper helper = table.getPrunedPartitionHelper(condition, rexBuilder); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/23142/3/java/calcite-planner/src/test/java/org/apache/impala/planner/TestCalciteStats.java@363 PS3, Line 363: PrunedPartitionHelper helper = table.getPrunedPartitionHelper(condition, rexBuilder); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/23142/3/tests/query_test/test_sort.py File tests/query_test/test_sort.py: http://gerrit.cloudera.org:8080/#/c/23142/3/tests/query_test/test_sort.py@178 PS3, Line 178: ( flake8: E275 missing whitespace after keyword -- To view, visit http://gerrit.cloudera.org:8080/23142 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04daf8395110f84300246643a62bffeedddf57ef Gerrit-Change-Number: 23142 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 07 Jul 2025 21:20:43 +0000 Gerrit-HasComments: Yes
