Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22967 )
Change subject: IMPALA-14115: Calcite planner: Added top-n analytic PlanNode optimization. ...................................................................... Patch Set 4: (1 comment) The limit-pushdown-analytics test did reveal some issues. Those are fixed now http://gerrit.cloudera.org:8080/#/c/22967/4/testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q44.test File testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q44.test: http://gerrit.cloudera.org:8080/#/c/22967/4/testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q44.test@325 PS4, Line 325: | | 19:SELECT : | | | predicates: rank() < CAST(11 AS BIGINT) : | | | mem-estimate=0B mem-reservation=0B thread-reservation=0 : | | | tuple-ids=28,27 row-size=32B cardinality=1 cost=10 : | | | in pipelines: 38(GETNEXT) : | | | : | | 18:SELECT : | | | predicates: rank() < CAST(11 AS BIGINT) : | | | mem-estimate=0B mem-reservation=0B thread-reservation=0 : | | | tuple-ids=28,27 row-size=32B cardinality=10 cost=10 : | | | in pipelines: 38(GETNEXT) > These 2 plan nodes are doing the same operation. One of them is redundant. When I tested against limit-pushdown-analytics, this got revealed as well. Latest fix now has only one SELECT -- To view, visit http://gerrit.cloudera.org:8080/22967 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5697a65a16ee7902ac492ed20168ac66e1d01a91 Gerrit-Change-Number: 22967 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Sat, 05 Jul 2025 01:31:29 +0000 Gerrit-HasComments: Yes
