Hello Kurt Deschler, Yida Wu, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23073
to look at the new patch set (#3).
Change subject: IMPALA-13887: Incorporate column/field information into cache
key
......................................................................
IMPALA-13887: Incorporate column/field information into cache key
The correctness verification for the tuple cache found an issue
with TestParquet::test_resolution_by_name(). The test creates a
table, selects, alters the table to change a column name, and
selects again. With parquet_fallback_schema_resolution=NAME, the
column names determine behavior. The tuple cache key did not
include the column names, so it was producing an incorrect result
after changing the column name.
This change adds information about the column / field name to the
TSlotDescriptor so that it is incorporated into the tuple cache key.
This is only needed when producing the tuple cache key, so it is
omitted for other cases.
Testing:
- Ran TestParquet::test_resolution_by_name() with correctness
verification
- Added custom cluster test that runs the test_resolution_by_name()
test case with tuple caching. This fails without this change.
Change-Id: Iebfa777452daf66851b86383651d35e1b0a5f262
---
M common/thrift/Descriptors.thrift
M fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java
M
testdata/workloads/functional-query/queries/QueryTest/parquet-resolution-by-name.test
M tests/custom_cluster/test_tuple_cache.py
4 files changed, 37 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/23073/3
--
To view, visit http://gerrit.cloudera.org:8080/23073
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iebfa777452daf66851b86383651d35e1b0a5f262
Gerrit-Change-Number: 23073
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com>
Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com>
