Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23081 )
Change subject: IMPALA-14164: Fix timeout for fragments in flight in TestScratchDir ...................................................................... Patch Set 1: Code-Review+1 (1 comment) lgtm, but I think that waiting for num-fragments-in-flight is not the best way to handle these tests http://gerrit.cloudera.org:8080/#/c/23081/1/tests/custom_cluster/test_scratch_disk.py File tests/custom_cluster/test_scratch_disk.py: http://gerrit.cloudera.org:8080/#/c/23081/1/tests/custom_cluster/test_scratch_disk.py@238 PS1, Line 238: # There are two fragments, but one can finish so quickly that the metric is never : # sampled as 2. Instead, wait for the metric to reach 1. : verifier.wait_for_metric("impala-server.num-fragments-in-flight", 1) Wouldn't it be clearer + simpler to wait for the query to have rows available? At that point (unless result spooling consumes the whole data) the query must have spilled runs. -- To view, visit http://gerrit.cloudera.org:8080/23081 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8c573affc033056ba465c42bd420d5c1d3ba15c Gerrit-Change-Number: 23081 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Tue, 24 Jun 2025 05:58:25 +0000 Gerrit-HasComments: Yes
