Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/22603 )
Change subject: IMPALA-10349: Support constant folding for non ascii strings ...................................................................... Patch Set 11: (10 comments) http://gerrit.cloudera.org:8080/#/c/22603/9/common/thrift/Exprs.thrift File common/thrift/Exprs.thrift: http://gerrit.cloudera.org:8080/#/c/22603/9/common/thrift/Exprs.thrift@121 PS9, Line 121: 1: required binary value; > As Michael mentioned, TStringLiteral is used in TColumn which has a 'defaul Before PS11 non-UTF8 default values hit a precondition. Added checks for this in the analyzer to get better error message and added a few tests. Non-utf8 defaults could make sense for BINARY columns, but found out that those don't work anyway, created ticket IMPALA-14173 http://gerrit.cloudera.org:8080/#/c/22603/10/fe/src/main/java/org/apache/impala/analysis/LiteralExpr.java File fe/src/main/java/org/apache/impala/analysis/LiteralExpr.java: http://gerrit.cloudera.org:8080/#/c/22603/10/fe/src/main/java/org/apache/impala/analysis/LiteralExpr.java@303 PS10, Line 303: // Sublcass implementations do not handle comparison with other Literal types. > This looks weird. Do we have a JIRA to further investigate this? Changed it to Precondition, if no test hits it, then I think that it is ok like this, the way it worked really didn't make sense. http://gerrit.cloudera.org:8080/#/c/22603/10/fe/src/main/java/org/apache/impala/analysis/StringLiteral.java File fe/src/main/java/org/apache/impala/analysis/StringLiteral.java: http://gerrit.cloudera.org:8080/#/c/22603/10/fe/src/main/java/org/apache/impala/analysis/StringLiteral.java@24 PS10, Line 24: import java.util.Arrays; : > nit: not used Done http://gerrit.cloudera.org:8080/#/c/22603/10/fe/src/main/java/org/apache/impala/analysis/StringLiteral.java@27 PS10, Line 27: import org.apache.impala.catalog.ScalarType; : import org.apache.impala.catalog.Type; : import org.apache.impala.catalog.Ty > nit: not used Done http://gerrit.cloudera.org:8080/#/c/22603/10/fe/src/main/java/org/apache/impala/analysis/StringLiteral.java@76 PS10, Line 76: inValue_ = v > nit: "It is ok to" ? Done http://gerrit.cloudera.org:8080/#/c/22603/10/fe/src/main/java/org/apache/impala/analysis/StringLiteral.java@148 PS10, Line 148: > Will this fail? Yes, it failed in some tests, forgot to remove it completely. http://gerrit.cloudera.org:8080/#/c/22603/10/fe/src/main/java/org/apache/impala/analysis/StringLiteral.java@209 PS10, Line 209: > nit: "hex" Done http://gerrit.cloudera.org:8080/#/c/22603/10/fe/src/main/java/org/apache/impala/analysis/StringLiteral.java@247 PS10, Line 247: // We allow simple chaining of MINUS to recognize negative numbers. > Can we add error messages to such new Preconditions.checkState() call sites Done http://gerrit.cloudera.org:8080/#/c/22603/10/fe/src/main/java/org/apache/impala/analysis/StringLiteral.java@299 PS10, Line 299: > nit: has an extra space Done http://gerrit.cloudera.org:8080/#/c/22603/10/fe/src/main/java/org/apache/impala/util/StringUtils.java File fe/src/main/java/org/apache/impala/util/StringUtils.java: http://gerrit.cloudera.org:8080/#/c/22603/10/fe/src/main/java/org/apache/impala/util/StringUtils.java@37 PS10, Line 37: Preconditions.checkState(false); : return null; > Do we want to return null or throw an IllegalStateException by checkState() The goal is to throw exception, the return null is just for the compiler. -- To view, visit http://gerrit.cloudera.org:8080/22603 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70663457a0b0a3443e586350f0a5996bb75ba64a Gerrit-Change-Number: 22603 Gerrit-PatchSet: 11 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Fri, 20 Jun 2025 18:45:09 +0000 Gerrit-HasComments: Yes
