Mihaly Szjatinya has uploaded a new patch set (#19). ( http://gerrit.cloudera.org:8080/22901 )
Change subject: IMPALA-13912: Use SHARED_CLUSTER_ARGS in more custom cluster tests ...................................................................... IMPALA-13912: Use SHARED_CLUSTER_ARGS in more custom cluster tests In addition to IMPALA-13503 which allowed having the single cluster running for the entire test class, this attempts to minimize restarting between the existing tests without modifying any of their code. This changeset saves the command line with which 'start-impala-cluster.py' has been run and skips the restarting if the command line is the same for the next test. Some tests however do require restart due to the specific metrics being tested. Such tests are defined with the 'force_restart' flag within the 'with_args' decorator. NOTE: there might be more tests like that revealed after running the tests in different order resulting in test failures. Experimentally, this results in ~150 fewer restarts, mostly coming from restarts between tests. As for restarts between different variants of the same test, most of the cluster tests are restricted to single variant, although multi-variant tests occur occasionally. Change-Id: I7c9115d4d47b9fe0bfd9dbda218aac2fb02dbd09 --- M tests/common/custom_cluster_test_suite.py M tests/custom_cluster/test_admission_controller.py M tests/custom_cluster/test_codegen_cache.py M tests/custom_cluster/test_kill_query.py M tests/custom_cluster/test_krpc_metrics.py M tests/custom_cluster/test_kudu.py M tests/custom_cluster/test_local_catalog.py M tests/custom_cluster/test_query_log.py M tests/custom_cluster/test_query_retries.py M tests/custom_cluster/test_restart_services.py M tests/custom_cluster/test_shell_interactive.py M tests/custom_cluster/test_shell_interactive_reconnect.py 12 files changed, 90 insertions(+), 28 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/22901/19 -- To view, visit http://gerrit.cloudera.org:8080/22901 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7c9115d4d47b9fe0bfd9dbda218aac2fb02dbd09 Gerrit-Change-Number: 22901 Gerrit-PatchSet: 19 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]>
