Anonymous Coward (816) has posted comments on this change. ( http://gerrit.cloudera.org:8080/22870 )
Change subject: IMPALA-14061: Calcite Planner: added Calcite rules ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/22870/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java: http://gerrit.cloudera.org:8080/#/c/22870/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java@90 PS7, Line 90: @Override : public List<String> getColLabels() { : List<String> colLabels = new ArrayList<>(); : int colCnt = rootNode_.outputExprs_.size(); : for (int i = 0; i < colCnt; ++i) { : colLabels.add(rootNode_.outputExprs_.get(i).toString()); : } : return colLabels; : } in https://gerrit.cloudera.org/#/c/22117/ change from @Override public List<String> getColLabels() { List<String> colLabels = new ArrayList<>(); int colCnt = rootNode_.outputExprs_.size(); for (int i = 0; i < colCnt; ++i) { colLabels.add(rootNode_.outputExprs_.get(i).toString()); } return colLabels; } to @Override public List<String> getColLabels() { return rootNode_.fieldNames_; } in this pr, does this revert really need? -- To view, visit http://gerrit.cloudera.org:8080/22870 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6671f7ed298a18965ef0b7a5fc10f4912333a52b Gerrit-Change-Number: 22870 Gerrit-PatchSet: 7 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Tue, 17 Jun 2025 02:18:18 +0000 Gerrit-HasComments: Yes
