Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23010
Change subject: IMPALA-13964: Fix test_tuple_cache_tpc_queries.py flakiness ...................................................................... IMPALA-13964: Fix test_tuple_cache_tpc_queries.py flakiness This makes two changes to deflake test_tuple_cache_tpc_queries.py. First, it increases the runtime filter wait time from 60 seconds to 600 seconds. The correctness verification slows down the path that produces the runtime filter. The slowdown is dependent on the speed of storage, so this can get very slow on test machines. Second,this skips correctness checking for locations that are just after streaming aggregations. Streaming aggregations can produce variable output that the correctness checking can't handle. For example a grouping aggregation computing a sum might have a preaggregation produce either (A: 3) or (A: 2), (A: 1) or (A: 1), (A: 1), (A:1). The finalization sees these as equivalent. This marks the nodes as variable starting with the preaggregation and clears the mark at the finalize stage. When skipping correctness checking, the tuple cache node does not hit the cache normally. This guarantees that its children will run and go through correctness checking. Testing: - Ran test_tuple_cache_tpc_queries.py locally - Added a frontend test for this specific case Change-Id: If5e1be287bdb489a89aea3b2d7bec416220feb9a --- M be/src/exec/tuple-cache-node.cc M be/src/exec/tuple-cache-node.h M common/thrift/PlanNodes.thrift M fe/src/main/java/org/apache/impala/common/ThriftSerializationCtx.java M fe/src/main/java/org/apache/impala/planner/AggregationNode.java M fe/src/main/java/org/apache/impala/planner/TupleCacheInfo.java M fe/src/main/java/org/apache/impala/planner/TupleCacheNode.java M fe/src/main/java/org/apache/impala/planner/TupleCachePlanner.java M fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java M tests/query_test/test_tuple_cache_tpc_queries.py 10 files changed, 136 insertions(+), 29 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/23010/1 -- To view, visit http://gerrit.cloudera.org:8080/23010 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If5e1be287bdb489a89aea3b2d7bec416220feb9a Gerrit-Change-Number: 23010 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]>
