Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22956 )
Change subject: IMPALA-14107: Increment table version in fireReloadEvent ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/22956/7/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/22956/7/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7324 PS7, Line 7324: boolean hasTableLock = tbl.isWriteLockedByCurrentThread(); > It is probably fine though, since catalog_.getLock().writeLock().lock() ins Just realized that catalog_.incrementAndGetCatalogVersion() itself will obtain versionLock_.writeLock().lock() inside. So this is safe. -- To view, visit http://gerrit.cloudera.org:8080/22956 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1bc91023d46a0b57916202d2b64e2cf07b687b74 Gerrit-Change-Number: 22956 Gerrit-PatchSet: 7 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Mon, 09 Jun 2025 20:09:06 +0000 Gerrit-HasComments: Yes
