Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22924 )
Change subject: IMPALA-13235: Update the build toolchain to include the latest OpenTelemetry C++ sdk. ...................................................................... Patch Set 8: (7 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22924/8/be/src/observe/otel-flags.cc File be/src/observe/otel-flags.cc: http://gerrit.cloudera.org:8080/#/c/22924/8/be/src/observe/otel-flags.cc@147 PS8, Line 147: DEFINE_string(otel_tls_minimum_version, "", "String containing the minimum allowed TLS version, " line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/22924/8/be/src/observe/otel-flags.cc@171 PS8, Line 171: DEFINE_double(otel_retry_policy_initial_backoff_s, 1.0, "Initial backoff delay between retry " line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/22924/8/be/src/observe/otel-flags.cc@174 PS8, Line 174: DEFINE_validator(otel_retry_policy_initial_backoff_s, [](const char* flagname, double value) { line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/22924/8/be/src/observe/otel-flags.cc@188 PS8, Line 188: DEFINE_validator(otel_retry_policy_backoff_multiplier, [](const char* flagname, double value) { line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/22924/8/be/src/observe/otel.cc File be/src/observe/otel.cc: http://gerrit.cloudera.org:8080/#/c/22924/8/be/src/observe/otel.cc@60 PS8, Line 60: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22924/8/be/src/observe/otel.cc@77 PS8, Line 77: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22924/8/be/src/observe/otel.cc@87 PS8, Line 87: auto processor = std::unique_ptr<SpanProcessor>(new SimpleSpanProcessor(std::move(exporter))); line too long (98 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22924 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie40b5cd33274df13f3005bf7a704299ebfff8a5b Gerrit-Change-Number: 22924 Gerrit-PatchSet: 8 Gerrit-Owner: gaurav singh <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Fri, 06 Jun 2025 23:26:34 +0000 Gerrit-HasComments: Yes
