Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22948 )

Change subject: IMPALA-12162: (addendum) Move test_parallel_checksum
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/22948/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/22948/1//COMMIT_MSG@11
PS1, Line 11:
> nit: add "in exhaustive builds"
Done


http://gerrit.cloudera.org:8080/#/c/22948/1//COMMIT_MSG@12
PS1, Line 12: option (in exhaustive builds) that is not compatible with 
text/none
> Could you explain more on how it fails? I see the test creates the table ba
These are the test that filed in exhaustive tests.

query_test.test_insert.TestInsertQueries.test_parallel_checksum[protocol: hs2 | 
table_format: parquet/none | exec_option: {'disable_codegen_rows_threshold': 0, 
'test_replan': 1, 'compression_codec': 'snappy', 'batch_size': 0, 'num_nodes': 
0, 'sync_ddl': 1, 'disable_codegen': True, 'abort_on_error': 1, 
'exec_single_node_rows_threshold': 0}]
query_test.test_insert.TestInsertQueries.test_parallel_checksum[protocol: hs2 | 
table_format: parquet/none | exec_option: {'disable_codegen_rows_threshold': 0, 
'test_replan': 1, 'compression_codec': 'gzip', 'batch_size': 0, 'num_nodes': 0, 
'sync_ddl': 0, 'disable_codegen': False, 'abort_on_error': 1, 
'exec_single_node_rows_threshold': 0}]
query_test.test_insert.TestInsertQueries.test_parallel_checksum[protocol: hs2 | 
table_format: parquet/none | exec_option: {'disable_codegen_rows_threshold': 0, 
'test_replan': 1, 'compression_codec': 'zstd', 'batch_size': 0, 'num_nodes': 0, 
'sync_ddl': 1, 'disable_codegen': False, 'abort_on_error': 1, 
'exec_single_node_rows_threshold': 0}]
query_test.test_insert.TestInsertQueries.test_parallel_checksum[protocol: hs2 | 
table_format: parquet/none | exec_option: {'disable_codegen_rows_threshold': 0, 
'test_replan': 1, 'compression_codec': 'lz4', 'batch_size': 0, 'num_nodes': 0, 
'sync_ddl': 1, 'disable_codegen': False, 'abort_on_error': 1, 
'exec_single_node_rows_threshold': 0}]
query_test.test_insert.TestInsertQueries.test_parallel_checksum[protocol: hs2 | 
table_format: parquet/none | exec_option: {'disable_codegen_rows_threshold': 0, 
'test_replan': 1, 'compression_codec': 'lz4', 'batch_size': 0, 'num_nodes': 0, 
'sync_ddl': 0, 'disable_codegen': False, 'abort_on_error': 1, 
'exec_single_node_rows_threshold': 0}]
query_test.test_insert.TestInsertQueries.test_parallel_checksum[protocol: hs2 | 
table_format: parquet/none | exec_option: {'disable_codegen_rows_threshold': 0, 
'test_replan': 1, 'compression_codec': 'zstd', 'batch_size': 0, 'num_nodes': 0, 
'sync_ddl': 0, 'disable_codegen': False, 'abort_on_error': 1, 
'exec_single_node_rows_threshold': 0}]
query_test.test_insert.TestInsertQueries.test_parallel_checksum[protocol: hs2 | 
table_format: parquet/none | exec_option: {'disable_codegen_rows_threshold': 0, 
'test_replan': 1, 'compression_codec': 'gzip', 'batch_size': 0, 'num_nodes': 0, 
'sync_ddl': 1, 'disable_codegen': False, 'abort_on_error': 1, 
'exec_single_node_rows_threshold': 0}]
query_test.test_insert.TestInsertQueries.test_parallel_checksum[protocol: hs2 | 
table_format: parquet/none | exec_option: {'disable_codegen_rows_threshold': 0, 
'test_replan': 1, 'compression_codec': 'snappy', 'batch_size': 0, 'num_nodes': 
0, 'sync_ddl': 1, 'disable_codegen': False, 'abort_on_error': 1, 
'exec_single_node_rows_threshold': 0}]
query_test.test_insert.TestInsertQueries.test_parallel_checksum[protocol: hs2 | 
table_format: parquet/none | exec_option: {'disable_codegen_rows_threshold': 0, 
'test_replan': 1, 'compression_codec': 'snappy', 'batch_size': 0, 'num_nodes': 
0, 'sync_ddl': 0, 'disable_codegen': False, 'abort_on_error': 1, 
'exec_single_node_rows_threshold': 0}]
query_test.test_insert.TestInsertQueries.test_parallel_checksum[protocol: hs2 | 
table_format: parquet/none | exec_option: {'disable_codegen_rows_threshold': 0, 
'test_replan': 1, 'compression_codec': 'gzip', 'batch_size': 0, 'num_nodes': 0, 
'sync_ddl': 0, 'disable_codegen': True, 'abort_on_error': 1, 
'exec_single_node_rows_threshold': 0}]
query_test.test_insert.TestInsertQueries.test_parallel_checksum[protocol: hs2 | 
table_format: parquet/none | exec_option: {'disable_codegen_rows_threshold': 0, 
'test_replan': 1, 'compression_codec': 'zstd', 'batch_size': 0, 'num_nodes': 0, 
'sync_ddl': 1, 'disable_codegen': True, 'abort_on_error': 1, 
'exec_single_node_rows_threshold': 0}]
query_test.test_insert.TestInsertQueries.test_parallel_checksum[protocol: hs2 | 
table_format: parquet/none | exec_option: {'disable_codegen_rows_threshold': 0, 
'test_replan': 1, 'compression_codec': 'lz4', 'batch_size': 0, 'num_nodes': 0, 
'sync_ddl': 1, 'disable_codegen': True, 'abort_on_error': 1, 
'exec_single_node_rows_threshold': 0}]
query_test.test_insert.TestInsertQueries.test_parallel_checksum[protocol: hs2 | 
table_format: parquet/none | exec_option: {'disable_codegen_rows_threshold': 0, 
'test_replan': 1, 'compression_codec': 'lz4', 'batch_size': 0, 'num_nodes': 0, 
'sync_ddl': 0, 'disable_codegen': True, 'abort_on_error': 1, 
'exec_single_node_rows_threshold': 0}]
query_test.test_insert.TestInsertQueries.test_parallel_checksum[protocol: hs2 | 
table_format: parquet/none | exec_option: {'disable_codegen_rows_threshold': 0, 
'test_replan': 1, 'compression_codec': 'zstd', 'batch_size': 0, 'num_nodes': 0, 
'sync_ddl': 0, 'disable_codegen': True, 'abort_on_error': 1, 
'exec_single_node_rows_threshold': 0}]
query_test.test_insert.TestInsertQueries.test_parallel_checksum[protocol: hs2 | 
table_format: parquet/none | exec_option: {'disable_codegen_rows_threshold': 0, 
'test_replan': 1, 'compression_codec': 'gzip', 'batch_size': 0, 'num_nodes': 0, 
'sync_ddl': 1, 'disable_codegen': True, 'abort_on_error': 1, 
'exec_single_node_rows_threshold': 0}]
query_test.test_insert.TestInsertQueries.test_parallel_checksum[protocol: hs2 | 
table_format: parquet/none | exec_option: {'disable_codegen_rows_threshold': 0, 
'test_replan': 1, 'compression_codec': 'snappy', 'batch_size': 0, 'num_nodes': 
0, 'sync_ddl': 0, 'disable_codegen': True, 'abort_on_error': 1, 
'exec_single_node_rows_threshold': 0}]

Notice that vector contain compression_codec query option. I suspect 
compression_codec != none does not play well with text/none format and the CTAS 
query actually failed.



--
To view, visit http://gerrit.cloudera.org:8080/22948
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b2bc34ae48a2355ee1e6f6e9e42da9076adf96b
Gerrit-Change-Number: 22948
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Tue, 27 May 2025 02:36:44 +0000
Gerrit-HasComments: Yes

Reply via email to