Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22883 )
Change subject: IMPALA-13982: Support regular views for Calcite planner in Impala ...................................................................... Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/22883/13/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/CalciteDb.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/CalciteDb.java: http://gerrit.cloudera.org:8080/#/c/22883/13/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/CalciteDb.java@87 PS13, Line 87: // We do not have to call Schemas.analyzeView() in Apache Calcite as done in Nit: I don't think we need to mention anything about Schema.analyzerView() or ViewTableMacro (on line 83 also). A bit too much information. http://gerrit.cloudera.org:8080/#/c/22883/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteAnalysisDriver.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteAnalysisDriver.java: http://gerrit.cloudera.org:8080/#/c/22883/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteAnalysisDriver.java@104 PS11, Line 104: stmtTableCache_); > Thanks Steve! Ok, so if I'm understanding correctly, parsedSttmt_.getTablesInQuery(null) only contains TableNames (and views) that are in the query, but stmtTableCache_ also contains the underlying tables of the view, is that right? If so, then I get it, and this change seems right, thanks for the explanation! -- To view, visit http://gerrit.cloudera.org:8080/22883 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I600aae816727ae942fb221fae84c2aac63ae1893 Gerrit-Change-Number: 22883 Gerrit-PatchSet: 11 Gerrit-Owner: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Thu, 22 May 2025 05:41:33 +0000 Gerrit-HasComments: Yes
