Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22871 )
Change subject: IMPALA-12162: Checksum files before lock in INSERT ...................................................................... Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/22871/6/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/22871/6/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7918 PS6, Line 7918: } > I think it's OK to send empty checksums. But if 'metadata' is null, we can' Done http://gerrit.cloudera.org:8080/#/c/22871/9/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/22871/9/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7884 PS9, Line 7884: FileSystem fs = FeFsTable.getFileSystem(filePath); > nit: it'd be better to keep using the 'tableFs' for unpartitioned tables. I'll add it back. Adds a bit more exception handling that's kind of awkward. http://gerrit.cloudera.org:8080/#/c/22871/9/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7891 PS9, Line 7891: file, table.getFullName(), ex); > I think you missed the Iceberg table condition here? I intentionally removed it. I'll add a comment to the commit. -- To view, visit http://gerrit.cloudera.org:8080/22871 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I18f9686f5d53cf1e7c384684c25427fb5353e2af Gerrit-Change-Number: 22871 Gerrit-PatchSet: 9 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Wed, 21 May 2025 16:57:40 +0000 Gerrit-HasComments: Yes
