Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22922 )
Change subject: IMPALA-13625: Allow reading Parquet int32/int64 as decimal without logical types ...................................................................... Patch Set 1: (2 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22922/1/be/src/exec/parquet/parquet-metadata-utils.cc File be/src/exec/parquet/parquet-metadata-utils.cc: http://gerrit.cloudera.org:8080/#/c/22922/1/be/src/exec/parquet/parquet-metadata-utils.cc@380 PS1, Line 380: Substitute("schema_element.name: $0, schema_element.type: $1, slot_desc->type().type: $2", line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/22922/1/be/src/exec/parquet/parquet-metadata-utils.cc@381 PS1, Line 381: schema_element.name, to_string(schema_element.type), TypeToString(slot_desc->type().type)) line too long (100 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22922 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56006eb3cca28c81ec8467d77b35005fbf669680 Gerrit-Change-Number: 22922 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Vanko <vankodanie...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Tue, 20 May 2025 13:09:05 +0000 Gerrit-HasComments: Yes
