Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22871 )
Change subject: IMPALA-12162: Checksum files before lock in INSERT ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/22871/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/22871/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@a7843 PS3, Line 7843: : : : : > Are these dead codes so being removed? I think so. The TODO ticket has been resolved. http://gerrit.cloudera.org:8080/#/c/22871/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7306 PS3, Line 7306: catalog_.getLock().writeLock().unlock(); : } : } > We don't need the checksums if shouldGenerateInsertEvents(table) returns fa Good point, I was going to address that and forgot. Done. http://gerrit.cloudera.org:8080/#/c/22871/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7814 PS3, Line 7814: * Helper method to prepare InsertEventRequestData. Also collect the list of > nit: use "/** */" type comments like other methods. Done http://gerrit.cloudera.org:8080/#/c/22871/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7843 PS3, Line 7843: LinkedHashSet<String> existingPartsInHms) { > nit: need a method comment to explain what are in 'fileInsertMetadata'. Added a class to clarify the argument's contents. http://gerrit.cloudera.org:8080/#/c/22871/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7852 PS3, Line 7852: long eventId = eventIds.get(par_idx++); > Could you comment on what scenarios have null checksums? If some files have I think it shouldn't, was overly cautious here. Removed the check. -- To view, visit http://gerrit.cloudera.org:8080/22871 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I18f9686f5d53cf1e7c384684c25427fb5353e2af Gerrit-Change-Number: 22871 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Mon, 19 May 2025 22:50:58 +0000 Gerrit-HasComments: Yes
