Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22869 )
Change subject: IMPALA-14051: Use batch insert HMS API to fire insert events ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/22869/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/22869/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@468 PS1, Line 468: hiveClient.addWriteNotificationLogInBatch(rqst); > This is a client side addition only. HMS server version is already included We also build Impala with Hive 3.1.3. I guess if that compiles we're fine, but https://github.com/apache/hive/blob/rel/release-3.1.3/standalone-metastore/src/main/thrift/hive_metastore.thrift doesn't mention WriteNotificationLogBatchRequest. -- To view, visit http://gerrit.cloudera.org:8080/22869 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff4a2691631fe9e9e1dc07714c69580a4ace6a8b Gerrit-Change-Number: 22869 Gerrit-PatchSet: 2 Gerrit-Owner: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Mon, 19 May 2025 18:49:13 +0000 Gerrit-HasComments: Yes
