Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22861 )

Change subject: IMPALA-14031: Enable keepalive by default for client connections
......................................................................


Patch Set 1: Code-Review+2

> Patch Set 1:
>
> After looking at this a bit, the test depends on that specific value of 600, 
> as it is parsing the keepalive timers and verifying the time value. I think I 
> would rather leave it specified in the test itself so that it doesn't depend 
> on the default value.

Ack.


--
To view, visit http://gerrit.cloudera.org:8080/22861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie358b5cabaff884516f7117d20d18c25124e59d5
Gerrit-Change-Number: 22861
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Comment-Date: Mon, 19 May 2025 17:33:06 +0000
Gerrit-HasComments: No

Reply via email to