Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22883 )
Change subject: IMPALA-13982: Support regular views for Calcite planner in Impala ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/22883/10/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaViewTableMacro.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaViewTableMacro.java: http://gerrit.cloudera.org:8080/#/c/22883/10/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaViewTableMacro.java@34 PS10, Line 34: public class ImpalaViewTableMacro extends ViewTableMacro { Something seems off to me about having to use "ViewTableMacro" instead of "ViewTable". ViewTable has its own private "expandView" called from "toRel" and seems like a more natural fit. It also extends AbstractQueryableTable, which seems to fit more into the "Table" world. I see ViewTableMacro just extends "Object". I was hoping that we could avoid a bit of the awkwardness in "apply" here where we call DriverManager.getConnection. My hope would be that if we could use "ViewTable" and it would be a cleaner interface. Have you tried this? If so, what issues did you hit where it couldn't be used? -- To view, visit http://gerrit.cloudera.org:8080/22883 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I600aae816727ae942fb221fae84c2aac63ae1893 Gerrit-Change-Number: 22883 Gerrit-PatchSet: 10 Gerrit-Owner: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Mon, 19 May 2025 14:58:14 +0000 Gerrit-HasComments: Yes
