Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22845 )
Change subject: IMPALA-13916: Change BaseTestSuite.default_test_protocol to HS2 ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/22845/5/tests/metadata/test_event_processing.py File tests/metadata/test_event_processing.py: http://gerrit.cloudera.org:8080/#/c/22845/5/tests/metadata/test_event_processing.py@644 PS5, Line 644: assert 'Partition: p=0' in res.runtime_profile These new asserts should include \n on the end of the string to ensure they don't match something like "Partition: p=01" or "NumModifiedRows: 10" http://gerrit.cloudera.org:8080/#/c/22845/5/tests/metadata/test_event_processing.py@657 PS5, Line 657: assert 'NumModifiedRows: 1' in res.runtime_profile These assertions aren't quite the same as the previous assertions. To do that needs regular expressions: assert re.search(r'\nPartition: p=0\nNumModifiedRows: 2\n', res.runtime_profile) is not None http://gerrit.cloudera.org:8080/#/c/22845/5/tests/query_test/test_errorlog.py File tests/query_test/test_errorlog.py: http://gerrit.cloudera.org:8080/#/c/22845/5/tests/query_test/test_errorlog.py@67 PS5, Line 67: self.client.close_query(handle) Should this line be in a finally block? http://gerrit.cloudera.org:8080/#/c/22845/5/tests/query_test/test_insert.py File tests/query_test/test_insert.py: http://gerrit.cloudera.org:8080/#/c/22845/5/tests/query_test/test_insert.py@311 PS5, Line 311: assert 'NumModifiedRows: 1' in res.runtime_profile Please add \n on the string. http://gerrit.cloudera.org:8080/#/c/22845/5/tests/query_test/test_insert.py@346 PS5, Line 346: assert 'NumModifiedRows: 1' in res.runtime_profile Please add \n on the string. -- To view, visit http://gerrit.cloudera.org:8080/22845 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42e9ceccbba1e6853f37e68f106265d163ccae28 Gerrit-Change-Number: 22845 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Thu, 15 May 2025 23:08:56 +0000 Gerrit-HasComments: Yes
