Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22900 )
Change subject: IMPALA-14049: Fix TSAN issue with HdrHistogram in expr-test ...................................................................... Patch Set 1: Code-Review+2 (1 comment) I think this is OK in test code. http://gerrit.cloudera.org:8080/#/c/22900/1/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/22900/1/be/src/exprs/expr-test.cc@230 PS1, Line 230: IGNORE_LEAKING_OBJECT(statestore_metrics); > Yes, the object will live for the lifetime of the process and not get freed Thanks for the explanation. -- To view, visit http://gerrit.cloudera.org:8080/22900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73c3f4db16c6ffa272f2512e9871db5743be7a54 Gerrit-Change-Number: 22900 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 15 May 2025 04:02:04 +0000 Gerrit-HasComments: Yes
