Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22899 )
Change subject: IMPALA-14072: Fix NPE in Catalogd during rename. ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/22899/2/tests/custom_cluster/test_concurrent_rename.py File tests/custom_cluster/test_concurrent_rename.py: http://gerrit.cloudera.org:8080/#/c/22899/2/tests/custom_cluster/test_concurrent_rename.py@56 PS2, Line 56: self.execute_query_ignore_exception("invalidate metadata {}2".format(name)) > Ah. That may be ok, or the test may later fail at line 62 if the timing's n In the logs, I see this INVALIDATE actually runs before the HMS RENAME RPC is done so tbl2 doesn't exist yet. I0514 07:25:17.680905 1776314 JniUtil.java:167] 1e4ffeb738d0ec7e:fc0207ce00000000] execDdl request: ALTER_TABLE test_rename_drop_aaefe83a.tbl RENAME_TABLE issued by jenkins ... I0514 07:25:17.779038 1776497 CatalogServiceCatalog.java:3016] c946ded100ff1f2b:dc0d912e00000000] Invalidating table metadata: test_rename_drop_aaefe83a.tbl2 ... E0514 07:25:18.204126 1776497 catalog-server.cc:368] c946ded100ff1f2b:dc0d912e00000000] TableNotFoundException: Table not found: test_rename_drop_aaefe83a.tbl2 I0514 07:25:18.213439 1776314 DebugUtils.java:176] 1e4ffeb738d0ec7e:fc0207ce00000000] Sleeping for 5000 msec to execute debug action catalogd_table_rename_delay Note that the sleep of debug action happens right after the HMS RENAME RPC is done. Can we retry this INVALIDATE tbl2 if it fails due to TableNotFoundException? This test aims to test concurrent INVALIDATE on the new table after the HMS RENAME RPC is done and before the AlterTableRename operation creates the new table in the cache. The sleep debug action should be able to let the retried INVALIDATE succeed. -- To view, visit http://gerrit.cloudera.org:8080/22899 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a421a71cf3703290645e85180de8e9d5e86368a Gerrit-Change-Number: 22899 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 15 May 2025 01:49:03 +0000 Gerrit-HasComments: Yes
