Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22897 )
Change subject: IMPALA-14071: Refactor MathUtil.saturatingMultiplyCardinalities() ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/22897/5/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java File fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java: http://gerrit.cloudera.org:8080/#/c/22897/5/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java@154 PS5, Line 154: d > nit: for single line ifs we usually omit the braces. Done http://gerrit.cloudera.org:8080/#/c/22897/5/fe/src/main/java/org/apache/impala/planner/NestedLoopJoinNode.java File fe/src/main/java/org/apache/impala/planner/NestedLoopJoinNode.java: http://gerrit.cloudera.org:8080/#/c/22897/5/fe/src/main/java/org/apache/impala/planner/NestedLoopJoinNode.java@98 PS5, Line 98: hild(1).avgRowSize_; : perInstanceMemEstimate = (long) Math.ceil(memMult); : } > In my experiments "(long) Math.ceil(Double.POSITIVE_INFINITY)" returns Long Done http://gerrit.cloudera.org:8080/#/c/22897/5/fe/src/main/java/org/apache/impala/planner/PlanNode.java File fe/src/main/java/org/apache/impala/planner/PlanNode.java: http://gerrit.cloudera.org:8080/#/c/22897/5/fe/src/main/java/org/apache/impala/planner/PlanNode.java@969 PS5, Line 969: > I don't mind changing the name. It will make the change bigger though. Done. Moved these to MathUtil. -- To view, visit http://gerrit.cloudera.org:8080/22897 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I505ab11cfa1024feb4ceac4cffe9c3283be228ce Gerrit-Change-Number: 22897 Gerrit-PatchSet: 7 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 14 May 2025 17:35:32 +0000 Gerrit-HasComments: Yes
