Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22872 )

Change subject: IMPALA-12162: Use thread pool to collect checksums
......................................................................


Patch Set 4:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/22872/4/fe/src/main/java/org/apache/impala/catalog/ParallelFileMetadataLoader.java
File fe/src/main/java/org/apache/impala/catalog/ParallelFileMetadataLoader.java:

http://gerrit.cloudera.org:8080/#/c/22872/4/fe/src/main/java/org/apache/impala/catalog/ParallelFileMetadataLoader.java@134
PS4, Line 134:           // Checks if we can reuse the old file descriptors. 
Partition builders in the list
line too long (92 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/22872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I314621104e4757620c0a90d41dd6875bf8855b51
Gerrit-Change-Number: 22872
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 May 2025 18:10:24 +0000
Gerrit-HasComments: Yes

Reply via email to