Surya Hebbar has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/22893 )
Change subject: IMPALA-14069: Factor possibility of zero timestamps in aggregated event sequences ...................................................................... IMPALA-14069: Factor possibility of zero timestamps in aggregated event sequences Currently, the missing event timestamps are substituted by zeros and then reported(i.e. unreported_event_instance_idxs) within event sequences of the JSON profile. See IMPALA-13555 for more details. Even with micro/nanosecond precision, some event timestamps are recorded as zeros (i.e. Prepare Finished - 0ns). The current implementation of aggregated event sequences was incorrectly considering these zeros as substituted missing timestamps. Although, these can be distinguished from missing timestamps through the exposed 'unreported_event_instance_idxs', it is more helpful to represent missing values as -ve values or constants(i.e. -1). This representation is favorable for summary and visualization, and is necessary for skipping missing values and maintaing alignment between instance timestamps. The patch also fixes null values in "info_strings" fields within the JSON profile. Fixed runtime-profile-test to consider -ve values(i.e. -1) as missing event timestamps, instead of 0. Updated the generated profiles in testdata/impala-profiles. Change-Id: I9f1efd2aad5f62084075cd8f9169ef72c66942b6 --- M be/src/util/runtime-profile-test.cc M be/src/util/runtime-profile.cc M testdata/impala-profiles/impala_profile_log_tpcds_compute_stats.expected.json M testdata/impala-profiles/impala_profile_log_tpcds_compute_stats.expected.pretty.json M testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_extended.expected.pretty.json 5 files changed, 166 insertions(+), 179 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/22893/2 -- To view, visit http://gerrit.cloudera.org:8080/22893 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9f1efd2aad5f62084075cd8f9169ef72c66942b6 Gerrit-Change-Number: 22893 Gerrit-PatchSet: 2 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]>
