Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22876 )
Change subject: IMPALA-14042: Deflake TestConcurrentRename.test_rename_drop ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/22876/2/tests/custom_cluster/test_concurrent_rename.py File tests/custom_cluster/test_concurrent_rename.py: http://gerrit.cloudera.org:8080/#/c/22876/2/tests/custom_cluster/test_concurrent_rename.py@52 PS2, Line 52: time.time() - start_time > Shouldn't it be time.time() - start_time? As it stands, the loop condition Oops, my bad. Raised from 1s to 10s. In my loop, each run is around 10s, so this should be sufficient. -- To view, visit http://gerrit.cloudera.org:8080/22876 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2539d5755aae6d375400b9a1289a658d0e7ba888 Gerrit-Change-Number: 22876 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Sun, 11 May 2025 04:38:07 +0000 Gerrit-HasComments: Yes
