Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22873 )

Change subject: IMPALA-14014: Fix COMPUTE STATS with TABLESAMPLE clause
......................................................................


Patch Set 1:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/22873/1/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java
File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java:

http://gerrit.cloudera.org:8080/#/c/22873/1/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@347
PS1, Line 347:     for (Map.Entry<Long, List<FileDescriptor>> entry : 
dataFilesWithDeletesSample.entrySet()) {
line too long (95 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/22873
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie59d5fc1374ab69209a74f2488bcb9a7d510b782
Gerrit-Change-Number: 22873
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 May 2025 14:19:56 +0000
Gerrit-HasComments: Yes

Reply via email to