Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/22245 )
Change subject: IMPALA-13624: Implement textual representation for aggregate event sequences ...................................................................... Patch Set 13: (1 comment) Thank you for the comments. http://gerrit.cloudera.org:8080/#/c/22245/13/testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_extended.expected.pretty.json File testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_extended.expected.pretty.json: http://gerrit.cloudera.org:8080/#/c/22245/13/testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_extended.expected.pretty.json@3024 PS13, Line 3024: 1135987328.0, 1139987328.0, 0.0, 0.0, 1147987200.0 > Why the average changes here? Is this precision issue that can be inconsist In the text profile and JSON's visual representations, as 3 digits after milliseconds were being represented mostly, I had switched from double to float for the averaged timestamps. If the precision of 50 nanoseconds is necessary, for the averaged timestamps, I can switch back to the representation with the double. As these were averaged timestamps, I was thinking this precision is sufficient. -- To view, visit http://gerrit.cloudera.org:8080/22245 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4bcc0e2e7fccfa8a184cfa8a3a96d68bfe6035c0 Gerrit-Change-Number: 22245 Gerrit-PatchSet: 13 Gerrit-Owner: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com> Gerrit-Comment-Date: Fri, 09 May 2025 10:40:27 +0000 Gerrit-HasComments: Yes
