Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22818 )
Change subject: IMPALA-13931: TestIcebergRestCatalog.test_rest_catalog_basic failed at setup ...................................................................... Patch Set 2: (4 comments) Thanks for the corrections! http://gerrit.cloudera.org:8080/#/c/22818/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22818/1//COMMIT_MSG@40 PS1, Line 40: bootst > In this clase, Java actually uses the bootstrap class loader, which has a v Done http://gerrit.cloudera.org:8080/#/c/22818/1/fe/src/main/java/org/apache/impala/util/IcebergMetadataScanner.java File fe/src/main/java/org/apache/impala/util/IcebergMetadataScanner.java: http://gerrit.cloudera.org:8080/#/c/22818/1/fe/src/main/java/org/apache/impala/util/IcebergMetadataScanner.java@83 PS1, Line 83: refl > Iceberg appears to use reflection, not JNDI You're right, fixed it here and at other places. http://gerrit.cloudera.org:8080/#/c/22818/1/java/iceberg-rest-catalog-test/pom.xml File java/iceberg-rest-catalog-test/pom.xml: http://gerrit.cloudera.org:8080/#/c/22818/1/java/iceberg-rest-catalog-test/pom.xml@94 PS1, Line 94: <artifactId>maven-dependency-plugin</artifactId> > Maven places the resources under src/test/resources on the classpath, but i Yeah, I had a version where I copied the .xml files to src/test/resources but I didn't really like that. The current solution seemed to be the least ugly, and it is also similar to what we already do in fe/pom.xml (and also in the calcite-planner/pom.xml). http://gerrit.cloudera.org:8080/#/c/22818/1/java/iceberg-rest-catalog-test/src/main/java/org/apache/iceberg/rest/IcebergRestCatalogTest.java File java/iceberg-rest-catalog-test/src/main/java/org/apache/iceberg/rest/IcebergRestCatalogTest.java: http://gerrit.cloudera.org:8080/#/c/22818/1/java/iceberg-rest-catalog-test/src/main/java/org/apache/iceberg/rest/IcebergRestCatalogTest.java@65 PS1, Line 65: LOG.info("Default filesystem configured for this Iceberg REST Catalog is " + > Should this log message have additional information to provide more context Good point, made it a bit more verbose. -- To view, visit http://gerrit.cloudera.org:8080/22818 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9dc0e30aeaff0b8de41426ba38506383b4af472c Gerrit-Change-Number: 22818 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 08 May 2025 09:02:59 +0000 Gerrit-HasComments: Yes
