Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22862 )
Change subject: IMPALA-14039: __restore_query_options should unset query option ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/22862/5/tests/common/impala_connection.py File tests/common/impala_connection.py: http://gerrit.cloudera.org:8080/#/c/22862/5/tests/common/impala_connection.py@238 PS5, Line 238: return DEFAULT_QUERY_OPTIONS.copy() > Do we want to keep this change from IMPALA-13930? Or remove get_default_con I'd like to keep it for now, in case I need to backport it. Will clean this up as separate patches. More codes need to be cleaned up following this removal. -- To view, visit http://gerrit.cloudera.org:8080/22862 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923 Gerrit-Change-Number: 22862 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Wed, 07 May 2025 19:16:26 +0000 Gerrit-HasComments: Yes