Daniel Becker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22863 )

Change subject: IMPALA-14040: Remove Kudu masters property from FeCatalog
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22863/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java:

http://gerrit.cloudera.org:8080/#/c/22863/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@38
PS2, Line 38: Before
We could use "@BeforeClass" instead, with a static method.



--
To view, visit http://gerrit.cloudera.org:8080/22863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcf31a724bb7bd00268accf21c0b997d92e9b23a
Gerrit-Change-Number: 22863
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <pro...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 May 2025 11:06:09 +0000
Gerrit-HasComments: Yes

Reply via email to