Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/22432 )
Change subject: IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same ...................................................................... Patch Set 4: (3 comments) Thanks! Nice to see that a small refactor unblocked this patch. Feel free to improve it and remove any code from getPartialInfo() that may be redundant. http://gerrit.cloudera.org:8080/#/c/22432/4/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java: http://gerrit.cloudera.org:8080/#/c/22432/4/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@499 PS4, Line 499: except nit: unless http://gerrit.cloudera.org:8080/#/c/22432/4/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@514 PS4, Line 514: Loading hdfs table after loaded schema from Iceberg, : // in case we create external Iceberg table skipping column info in sql. I know this comment is from the original code, but I find it difficult to understand. Could you please rephrase it? AFAIU it means something like: "In case we create an external Iceberg table, we load the schema from Iceberg and not from the column info provided in the SQL statement." http://gerrit.cloudera.org:8080/#/c/22432/4/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@551 PS4, Line 551: private void setIcebergApiTable(org.apache.iceberg.Table newIceTable) { unused method, see also the comment on L246 -- To view, visit http://gerrit.cloudera.org:8080/22432 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16727000cb11d1c0591875a6542d428564dce664 Gerrit-Change-Number: 22432 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 06 May 2025 12:05:15 +0000 Gerrit-HasComments: Yes
