Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22856 )
Change subject: IMPALA-14022: Use longer timeouts for rename test ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/22856/2/tests/metadata/test_ddl.py File tests/metadata/test_ddl.py: http://gerrit.cloudera.org:8080/#/c/22856/2/tests/metadata/test_ddl.py@523 PS2, Line 523: assert get_read_lock_duration_ms(profile1) < 5000 > nit: Should we add some slack here too? The read lock is usually done in <1ms. It was only before IMPALA-13631 that it would be affected by the sleep. -- To view, visit http://gerrit.cloudera.org:8080/22856 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3dcd7b93a37fc6d078fd562ae1c356596a758a6 Gerrit-Change-Number: 22856 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Mon, 05 May 2025 21:03:20 +0000 Gerrit-HasComments: Yes
