Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22844 )
Change subject: IMPALA-13850 (part 2): Stabilize test_restart_services.py ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/22844/1/tests/custom_cluster/test_restart_services.py File tests/custom_cluster/test_restart_services.py: http://gerrit.cloudera.org:8080/#/c/22844/1/tests/custom_cluster/test_restart_services.py@398 PS1, Line 398: monitor.wait_for_catalog_change() > This test is added in IMPALA-5476 for white box testing to execute the DDL IMPALA-13850 (part 1) make local catalog mode send statestore update twice: the first is to announce it availability and service id, while the second is the full topic update. This change can be limited to local catalog mode only. The one that urgently need fix through CatalogChangeMonitor is test_restart_catalogd_with_local_catalog below. http://gerrit.cloudera.org:8080/#/c/22844/1/tests/util/catalog_monitor.py File tests/util/catalog_monitor.py: http://gerrit.cloudera.org:8080/#/c/22844/1/tests/util/catalog_monitor.py@39 PS1, Line 39: changed = (old_id != new_id) > It'd be helpful to log the service ids and whether they changed. Ack. Will do. -- To view, visit http://gerrit.cloudera.org:8080/22844 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97f6f692506de0bbf2e1445f83bed824dc8298fd Gerrit-Change-Number: 22844 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Sat, 03 May 2025 05:39:03 +0000 Gerrit-HasComments: Yes