Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/21175 )
Change subject: IMPALA-12829: Skip processing transaction events if the table is HMS sync disabled. ...................................................................... Patch Set 8: (7 comments) http://gerrit.cloudera.org:8080/#/c/21175/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21175/7//COMMIT_MSG@17 PS7, Line 17: e need to : check if HMS sync is disabled on the H > Please explain the solution a little bit here. Ack http://gerrit.cloudera.org:8080/#/c/21175/7/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/21175/7/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@4516 PS7, Line 4516: tbl.releaseWriteLock(); : } : } : : pub > I think we can use the static method directly, i.e. MetastoreTableEvent.get I have referred to it using MetastoreTableEvent.getHmsSyncProperty(tbl); Moving this method to MetastoreEvent class and making it static makes getDbProperty() method non-accessible http://gerrit.cloudera.org:8080/#/c/21175/7/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@4523 PS7, Line 4523: } : Boolean tblFlagVal = MetastoreEvents.MetastoreTableEvent.getHmsSyncProperty( : tbl); : if (tblFlagVa > nit: can be simplified to Ack http://gerrit.cloudera.org:8080/#/c/21175/7/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/21175/7/tests/custom_cluster/test_events_custom_configs.py@1506 PS7, Line 1506: acid = AcidTxn(self.hive_client) > This duplicates L34. Ack http://gerrit.cloudera.org:8080/#/c/21175/7/tests/custom_cluster/test_events_custom_configs.py@1512 PS7, Line 1512: > Can we also test a non-partitioned table? Ack http://gerrit.cloudera.org:8080/#/c/21175/7/tests/custom_cluster/test_events_custom_configs.py@1515 PS7, Line 1515: self.run_stmt_in_hive(create_stmt) > stale comment Ack http://gerrit.cloudera.org:8080/#/c/21175/7/tests/custom_cluster/test_events_custom_configs.py@1539 PS7, Line 1539: tbls_refreshed_after = EventProcessorUtils.get_int_metric('tables-refreshed', 0) > These pass even without the fix. I think the reason is the table has no par Ack -- To view, visit http://gerrit.cloudera.org:8080/21175 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d0ecb3b756755bc04c66a538a9ae6b88011a019 Gerrit-Change-Number: 21175 Gerrit-PatchSet: 8 Gerrit-Owner: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Wed, 30 Apr 2025 21:52:14 +0000 Gerrit-HasComments: Yes
