Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22834 )

Change subject: IMPALA-13479: Patch gperftools to remove 1GB limit on thread 
caches
......................................................................


Patch Set 1:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/22834/1/be/src/runtime/exec-env.cc
File be/src/runtime/exec-env.cc:

http://gerrit.cloudera.org:8080/#/c/22834/1/be/src/runtime/exec-env.cc@503
PS1, Line 503:   if (actual_max_total_thread_cache_bytes != 
FLAGS_tcmalloc_max_total_thread_cache_bytes) {
line too long (91 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/22834
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If78c8734c704090c12737a8c2a8456b73ea4b8e8
Gerrit-Change-Number: 22834
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Comment-Date: Wed, 30 Apr 2025 00:37:37 +0000
Gerrit-HasComments: Yes

Reply via email to