Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22831 )
Change subject: IMPALA-11672: Update 'transient_lastDdlTime' for Iceberg tables ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/22831/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22831/2//COMMIT_MSG@9 PS2, Line 9: Update 'transient_lastDdlTime' after DDL operations including We could mention that 'transient_lastDdlTime' was not updated so far at all for Iceberg tables. http://gerrit.cloudera.org:8080/#/c/22831/2//COMMIT_MSG@18 PS2, Line 18: Nit: another http://gerrit.cloudera.org:8080/#/c/22831/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/22831/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1185 PS2, Line 1185: and also for This is a bit ambiguous to me, we could make this clearer. Maybe we could even split it into two cases: ... and refresh the table metadata except for - RENAME for Iceberg tables - RENAME, ADD PARTITION and DROP PARTITION for HDFS tables. Could also describe shortly why there is a difference between table formats. http://gerrit.cloudera.org:8080/#/c/22831/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1637 PS2, Line 1637: needsToUpdateHms What happens if 'needsToUpdateHms' is true? Will it be updated "automatically"? http://gerrit.cloudera.org:8080/#/c/22831/2/tests/metadata/test_last_ddl_time_update.py File tests/metadata/test_last_ddl_time_update.py: http://gerrit.cloudera.org:8080/#/c/22831/2/tests/metadata/test_last_ddl_time_update.py@277 PS2, Line 277: non-Kudu Could be "Hdfs table" now that we also have Iceberg, which is non-Kudu. -- To view, visit http://gerrit.cloudera.org:8080/22831 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e5f63b50bd37c80faf482c4baf4221be857c54b Gerrit-Change-Number: 22831 Gerrit-PatchSet: 2 Gerrit-Owner: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Comment-Date: Tue, 29 Apr 2025 14:04:50 +0000 Gerrit-HasComments: Yes
