Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22807 )
Change subject: IMPALA-13989: Invalidate table on rename failure ...................................................................... IMPALA-13989: Invalidate table on rename failure Handles the error "Table/view rename succeeded in the Hive Metastore, but failed in Impala's Catalog Server" rather than failing the table rename. This error happens when catalog state catches up to the alter event from our alter_table RPC to HMS before we renameTable explicitly in the catalog. The catalog can update independently due to a concurrent 'invalidate metadata' call. In that case we use the oldTbl definition we already have - updated from the delete log if possible - and fetch the new table definition with invalidateTable to continue, automating most of the work that the error message suggested users do via 'invalidate metadata <tbl>'. Updated the test_concurrent_ddls test to remove handle_rename_failure and ran the tests a dozen times. Adds concurrency tests with simultaneous rename and invalidate metadata that previously would fail. Change-Id: Ic2a276b6e5ceb35b7f3ce788cc47052387ae8980 Reviewed-on: http://gerrit.cloudera.org:8080/22807 Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java M tests/custom_cluster/test_concurrent_ddls.py A tests/custom_cluster/test_concurrent_rename.py 3 files changed, 116 insertions(+), 35 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/22807 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic2a276b6e5ceb35b7f3ce788cc47052387ae8980 Gerrit-Change-Number: 22807 Gerrit-PatchSet: 12 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
