Anonymous Coward (816) has posted comments on this change. ( http://gerrit.cloudera.org:8080/22105 )
Change subject: IMPALA-13517: Support overloaded || operator ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/22105/10/java/calcite-planner/src/main/codegen/templates/Parser.jj File java/calcite-planner/src/main/codegen/templates/Parser.jj: http://gerrit.cloudera.org:8080/#/c/22105/10/java/calcite-planner/src/main/codegen/templates/Parser.jj@7744 PS10, Line 7744: <PLUS> { return SqlStdOperatorTable.PLUS; } : | <MINUS> { return SqlStdOperatorTable.MINUS; } : | <STAR> { return SqlStdOperatorTable.MULTIPLY; } : | <SLASH> { return SqlStdOperatorTable.DIVIDE; } just out of curiosity, in ImpalaCustomOperatorTable, you redefine following: public static final SqlBinaryOperator PLUS = new SqlMonotonicBinaryOperator( "+", SqlKind.PLUS, 40, true, ADD_ADJUSTED_RETURN_TYPE_NULLABLE, InferTypes.FIRST_KNOWN, OperandTypes.PLUS_OPERATOR); public static final SqlBinaryOperator MINUS = new SqlMonotonicBinaryOperator( "-", SqlKind.MINUS, 40, true, MINUS_ADJUSTED_RETURN_TYPE_NULLABLE, InferTypes.FIRST_KNOWN, OperandTypes.MINUS_OPERATOR); public static final SqlBinaryOperator MULTIPLY = new SqlMonotonicBinaryOperator( "*", SqlKind.TIMES, 60, true, MULT_ADJUSTED_RETURN_TYPE_NULLABLE, InferTypes.FIRST_KNOWN, OperandTypes.MULTIPLY_OPERATOR); public static final SqlBinaryOperator DIVIDE = new SqlBinaryOperator( "/", SqlKind.DIVIDE, 60, true, DIVIDE_ADJUSTED_RETURN_TYPE_NULLABLE, InferTypes.FIRST_KNOWN, OperandTypes.DIVISION_OPERATOR); do we need change here to: | <PLUS> { return ImpalaCustomOperatorTable.PLUS; } | <MINUS> { return ImpalaCustomOperatorTable.MINUS; } | <STAR> { return ImpalaCustomOperatorTable.MULTIPLY; } | <SLASH> { return ImpalaCustomOperatorTable.DIVIDE; } http://gerrit.cloudera.org:8080/#/c/22105/10/java/calcite-planner/src/main/codegen/templates/Parser.jj@7754 PS10, Line 7754: ImpalaConcatOrOperator.INSTANCE in order to use CONCAT_OR you defined in ImpalaCustomOperatorTable, maybe here can change to ImpalaCustomOperatorTable.CONCAT_OR -- To view, visit http://gerrit.cloudera.org:8080/22105 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iabaf02e84b769db1419bd96e1d1b30b8f83d56f5 Gerrit-Change-Number: 22105 Gerrit-PatchSet: 10 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Mon, 28 Apr 2025 12:41:11 +0000 Gerrit-HasComments: Yes
